Checking parts of the message to combat flaky tests#1986
Checking parts of the message to combat flaky tests#1986knative-prow[bot] merged 1 commit intoknative:mainfrom
Conversation
knative-prow
bot
requested review from
evankanderson,
itsmurugappan and
vyasgun
![knative-prow[bot]](https://avatars.githubusercontent.com/in/183726?s=60&v=4){kind=small}
There was a problem hiding this comment.
@cardil: 0 warnings.
Details
In response to this:
Description
By checking for smaller parts of the expected TUI, we can effectively fix the flakiness, which comes primarily from race condition.
Changes
- Checking parts of the message to combat flaky
output/tui.TestSpinnerReference
Fixes #1985
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
knative-prow
bot
added
the
size/M
|
/assign @dsimansk |
|
/cc @dsimansk |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1986 +/- ##
=======================================
Coverage 73.70% 73.70%
=======================================
Files 234 234
Lines 16482 16482
=======================================
Hits 12148 12148
Misses 3506 3506
Partials 828 828 ☔ View full report in Codecov by Sentry. |
|
I assured this will fix the issue by doing: On main, it was failing even on Ref.: https://www.influxdata.com/blog/reproducing-a-flaky-test-in-go/ |
|
/test integration-tests |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
Failing on a serving setup step is strange. Flake? |
|
/retest |
2 participants
Description
By checking for smaller parts of the expected TUI, we can effectively fix the flakiness, which comes primarily from race condition.
Changes
output/tui.TestSpinnerReference
Fixes #1985